Use frames for progress ratio #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized that fps can have decimals like 23.976, will fix that in a bit |
|
Sounds good, wonder if this works for audio files as well? |
|
Right, audio, will add support for that too |
|
Added audio support (reverts to using duration for the ratio), fixed for fps values with decimal points and also ported the same logic to src/util/parseProgress.js (not sure where it is used but it was basically the same original function so i thought id give it the same treatment). Let me know what you think! |
|
LGTM! Thanks for the PR! |
jeromewu
added a commit
that referenced
this pull request
Aug 10, 2023
Use frames for progress ratio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using timestamps for progress was very inconsistent for me. When starting it would be stuck at 0% for quite a long time, then work normally up until 57%, stay stuck there a long while and then jump to 100%.
Using frames seems to work better, it starts the progress counter nearly instantly and it gets up to 100% just fine. It does stay stuck at 100% for a bit though, probably as it is finalizing.