Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage, clean and create/recreate scenarios added, tests refactored and fixed, workflows updated. #65

Merged
merged 63 commits into from
Sep 24, 2021
Merged

Coverage, clean and create/recreate scenarios added, tests refactored and fixed, workflows updated. #65

merged 63 commits into from
Sep 24, 2021

Conversation

panasevychol
Copy link
Contributor

@panasevychol panasevychol commented Sep 6, 2021 •
edited
Loading

Coverage, clean and create/recreate scenarios added. (closes #63 )

@panasevychol panasevychol self-assigned this Sep 6, 2021
5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 8, 2021
View reviewed changes
.github/workflows/workflow.yml Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 8, 2021
View reviewed changes
Makefile
.PHONY: clean-docs
clean-docs:
# Update when docs PR is merged to avoid conflicts
# rm -fr docs/build/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update when docs PR is merged

5A11
5A11 reviewed Sep 8, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 8, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@panasevychol panasevychol changed the title Coverage, clean and create/recreate scenarios added. Coverage, clean and create/recreate scenarios added, tests refactored and fixed, workflows updated. Sep 17, 2021
5A11
5A11 reviewed Sep 22, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@5A11
Copy link
Member

5A11 commented Sep 23, 2021

@panasevychol
For coverage, we need to add cover for the following:
cosmpy/tx/rest_client.py lines 62-65 and 100-101

Then please add everything under cosmos/protos to .coveragerc so they get ignored.

5A11
5A11 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@5A11 5A11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@5A11 5A11 merged commit 64456f5 into master Sep 24, 2021
@5A11 5A11 deleted the feature/coverage-report branch September 24, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5A11 5A11 5A11 approved these changes

Assignees

@panasevychol panasevychol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile options
2 participants
@panasevychol @5A11