Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto files moved to a separate proto module. #42

Merged
merged 33 commits into from
Aug 17, 2021
Merged

Proto files moved to a separate proto module. #42

merged 33 commits into from
Aug 17, 2021

Conversation

panasevychol
Copy link
Contributor

Proto files moved to a separate proto module.

@panasevychol panasevychol requested a review from 5A11 August 12, 2021 15:28
@panasevychol panasevychol self-assigned this Aug 12, 2021
5A11
5A11 reviewed Aug 12, 2021
View reviewed changes
proto/__init__.py Outdated Show resolved Hide resolved
@5A11
Copy link
Member

5A11 commented Aug 12, 2021

You forgot to make changes to makefile.

5A11
5A11 reviewed Aug 17, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
5A11
5A11 reviewed Aug 17, 2021
View reviewed changes
tests/helpers.py Outdated Show resolved Hide resolved
5A11
5A11 reviewed Aug 17, 2021
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@MissingNO57 MissingNO57 requested a review from 5A11 August 17, 2021 14:21
5A11
5A11 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@5A11 5A11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@5A11 5A11 merged commit bf8ba12 into master Aug 17, 2021
@5A11 5A11 deleted the feature/proto branch August 17, 2021 16:07
@MissingNO57 MissingNO57 mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5A11 5A11 5A11 approved these changes

Assignees

@panasevychol panasevychol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panasevychol @5A11 @MissingNO57