Tx generic signing & Tx module (the first take) #12

pbukva · 2021-07-19T07:38:32Z

No description provided.

…ning

src/cosm/crypto/address.py

src/cosm/tx/__init__.py

5A11 · 2021-07-19T12:00:26Z

src/cosm/tx/tx_rest_client.py

+ def Simulate(self, request: SimulateRequest) -> SimulateResponse:
+ json_request = MessageToDict(request)
+ response = self.rest_api.post(
+ f"/cosmos/tx/v1beta1/simulate",


Define this as a constant.

Use across (below)

This URL path is changing, and in general it is different per each call.

Though, in this prticular case, following 3 calls below share the same URL path (note: it is still different than un this first call).

I mean the /cosmos/tx/v1beta1/ part.

5A11 · 2021-07-20T11:07:19Z

src/cosm/tests/tx/test_tx.py

+ "FETCHD_GRPC_URL" not in os.environ, "Just for testing with local fetchd node"
+ )
+ def test_tx_broadcast(self):
+ # from_pk = PrivateKey(bytes.fromhex("8bdfbd2eaad5dc4324d19fabed72882709dc080b39e61044d51b91a6e38f6871"))


Remove unwanted code (also below).

5A11 · 2021-07-20T11:07:48Z

src/cosm/tests/tx/test_tx.py

+
+ tx_body = TxBody()
+ tx_body.memo = "very first tx"
+ # tx_body.timeout_height = 0xffffffffffffffff


5A11 · 2021-07-20T11:07:52Z

src/cosm/tests/tx/test_tx.py

+
+ from_pub_key_packed = Any()
+ from_pub_key_packed.Pack(from_pub_key_pb) # , type_url_prefix="/")
+ # signer_info.public_key = from_pub_key_packed


5A11 · 2021-07-20T11:07:56Z

src/cosm/tests/tx/test_tx.py

+ fee=Fee(amount=[Coin(amount="0", denom="afet")], gas_limit=200000),
+ )
+
+ # sd = SignDoc()


5A11 · 2021-07-20T11:08:41Z

src/cosm/tx/interface.py

+
+class RPCInterface(ABC):
+ # Simulate simulates executing a transaction for estimating gas usage.
+ def Simulate(self, request: svc.SimulateRequest) -> svc.SimulateResponse:


The best approach for abstract methods in python is to add @abstractmethod above the method, add docstring for the methods and have nothing in the body (remove ...).

The ... (or pass) must be left there, otherwise the it is syntactic error when removed.

Regarding @abstractmethod decorator, good catch, I just forgot to put the decorator on top of methods.

MissingNO57 · 2021-07-21T16:30:39Z

src/cosm/query/rest_client.py

@@ -1,27 +1,30 @@
-import urllib.error
-import urllib.request
+import requests


I see you reverted my changes.

Suggested change

import requests

import urllib.error

from urllib.request import Request, urlopen

class QueryRestClient:

def __init__(self, rest_address: str):

self.rest_address = rest_address

def get(self, request: str) -> str:

url = self.rest_address + request

try:

with urllib.request.urlopen(url) as f:

response = f.read().decode("utf-8")

return response

except urllib.error.HTTPError as e:

raise RuntimeError(

f"HTTPError when sending a get request.\n Request: {request}\n Response: {e.code}, {str(e.read().decode('utf-8'))})"

)

except urllib.error.URLError as e:

raise RuntimeError(

f"URLError when sending a get request.\n Request: {request}, Exception: {e})"

)

except Exception as e:

raise RuntimeError(

f"Exception during sending a get request.\n Request: {request}, Exception: {e})"

)

def post(self, url_path, json_request: dict) -> str:

try:

req = Request(self.rest_address + url_path)

req.add_header("Content-type", "application/json")

req.add_header("Accept", "application/json")

response = (

urlopen(req, data=str(json_request).encode("utf-8"))

.read()

.decode("utf-8")

)

return response

except urllib.error.HTTPError as e:

raise RuntimeError(

f"HTTPError when sending a get request.\n Request: {url_path}, with json data: {json_request}\n Response: {e.code}, {str(e.read().decode('utf-8'))})"

)

except urllib.error.URLError as e:

raise RuntimeError(

f"URLError when sending a get request.\n Request: {url_path}, with json data: {json_request}, Exception: {e})"

)

except Exception as e:

raise RuntimeError(

f"Exception during sending a get request.\n Request: {url_path}, with json data: {json_request}, Exception: {e})"

)

pbukva added 7 commits July 15, 2021 08:54

Construct & sign MsgSend transaction (concept impl. as uTest)

f0e7271

Add basic transastion signing (interface will be refined)

d7fdc67

Adj. sign_transaction(...) signature

de5420e

Merge branch 'master' into feat/tx_signing

726ef96

Support for canonical lower-S form signature (Secp256k1)

9052fcb

Merge branch 'feat/canonical_lower-s_form_signature' into feat/tx_sig…

497b31a

…ning

Adding post to rest client and relocating tx components

9ef707e

pbukva requested review from panasevychol, 5A11, ejfitzgerald and MissingNO57 July 19, 2021 07:38

pbukva self-assigned this Jul 19, 2021

pbukva changed the base branch from master to feat/canonical_lower-s_form_signature July 19, 2021 07:38

5A11 reviewed Jul 19, 2021

View reviewed changes

src/cosm/crypto/address.py Show resolved Hide resolved

5A11 reviewed Jul 19, 2021

View reviewed changes

src/cosm/tx/__init__.py Outdated Show resolved Hide resolved

5A11 reviewed Jul 19, 2021

View reviewed changes

Base automatically changed from feat/canonical_lower-s_form_signature to master July 20, 2021 07:58

pbukva added 3 commits July 20, 2021 09:01

Merge branch 'master' into feat/tx_signing

dec1398

Code formatting

7087788

Merge remote-tracking branch 'origin/master' into feat/tx_signing

f9e1476

5A11 reviewed Jul 20, 2021

View reviewed changes

src/cosm/tests/tx/test_tx.py Outdated

fee=Fee(amount=[Coin(amount="0", denom="afet")], gas_limit=200000),

)

# sd = SignDoc()

Copy link

Member

5A11 Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

5A11 reviewed Jul 20, 2021

View reviewed changes

pbukva added 5 commits July 20, 2021 12:38

Incorp. review findingsa

a2cd471

Incorp. review findings

1fc1179

Incorp. review findings

5e6a029

Incorp. review findings

81706e2

Incorp. review findings

47408cd

MissingNO57 mentioned this pull request Jul 21, 2021

Docs and examples #17

Merged

pbukva added 3 commits July 21, 2021 15:20

Merge branch 'master' into feat/tx_signing

9e121f8

Diching left-over print-out

d23e3dd

Adj. Pipfile

c980782

MissingNO57 reviewed Jul 21, 2021

View reviewed changes

pbukva added 2 commits July 21, 2021 22:56

Sorting outstanding inssue with importing indirect proto py type

96d0a77

Relocating tx uTest

091ac6c

pbukva merged commit cc4698f into master Jul 21, 2021

pbukva deleted the feat/tx_signing branch July 21, 2021 22:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tx generic signing & Tx module (the first take) #12

Tx generic signing & Tx module (the first take) #12

pbukva commented Jul 19, 2021

5A11 Jul 19, 2021

5A11 Jul 19, 2021

pbukva Jul 20, 2021

5A11 Jul 20, 2021

5A11 Jul 20, 2021 •

edited

Loading

5A11 Jul 20, 2021

5A11 Jul 20, 2021

5A11 Jul 20, 2021

5A11 Jul 20, 2021 •

edited

Loading

pbukva Jul 20, 2021

MissingNO57 Jul 21, 2021

-import requests
+import urllib.error
+from urllib.request import Request, urlopen
+class QueryRestClient:
+ def __init__(self, rest_address: str):
+ self.rest_address = rest_address
+ def get(self, request: str) -> str:
+ url = self.rest_address + request
+ try:
+ with urllib.request.urlopen(url) as f:
+ response = f.read().decode("utf-8")
+ return response
+ except urllib.error.HTTPError as e:
+ raise RuntimeError(
+ f"HTTPError when sending a get request.\n Request: {request}\n Response: {e.code}, {str(e.read().decode('utf-8'))})"
+ )
+ except urllib.error.URLError as e:
+ raise RuntimeError(
+ f"URLError when sending a get request.\n Request: {request}, Exception: {e})"
+ )
+ except Exception as e:
+ raise RuntimeError(
+ f"Exception during sending a get request.\n Request: {request}, Exception: {e})"
+ )
+ def post(self, url_path, json_request: dict) -> str:
+ try:
+ req = Request(self.rest_address + url_path)
+ req.add_header("Content-type", "application/json")
+ req.add_header("Accept", "application/json")
+ response = (
+ urlopen(req, data=str(json_request).encode("utf-8"))
+ .read()
+ .decode("utf-8")
+ )
+ return response
+ except urllib.error.HTTPError as e:
+ raise RuntimeError(
+ f"HTTPError when sending a get request.\n Request: {url_path}, with json data: {json_request}\n Response: {e.code}, {str(e.read().decode('utf-8'))})"
+ )
+ except urllib.error.URLError as e:
+ raise RuntimeError(
+ f"URLError when sending a get request.\n Request: {url_path}, with json data: {json_request}, Exception: {e})"
+ )
+ except Exception as e:
+ raise RuntimeError(
+ f"Exception during sending a get request.\n Request: {url_path}, with json data: {json_request}, Exception: {e})"
+ )

Tx generic signing & Tx module (the first take) #12

Tx generic signing & Tx module (the first take) #12

Conversation

pbukva commented Jul 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

5A11 Jul 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

5A11 Jul 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

5A11 Jul 20, 2021 •

edited

Loading

5A11 Jul 20, 2021 •

edited

Loading