Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redefined subarray in index.d.ts to return Buffer #298

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Redefined subarray in index.d.ts to return Buffer #298

merged 1 commit into from
Oct 8, 2023

Conversation

BTOdell
Copy link
Contributor

@BTOdell BTOdell commented Jun 18, 2021

Closes #297

@kinetikeith
Copy link

Could this pull be reviewed? It's been open since 2021.

kinetikeith
kinetikeith approved these changes Jan 28, 2023
View reviewed changes
Copy link

@kinetikeith kinetikeith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaration matches with official docs as well as the local implementation

@dcousens dcousens mentioned this pull request Oct 8, 2023
Closed
@dcousens dcousens merged commit 02b6885 into feross:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinetikeith kinetikeith kinetikeith approved these changes

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subarray is not re-defined in index.d.ts
3 participants
@BTOdell @kinetikeith @dcousens