Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oven fix mobile #18

Merged
merged 9 commits into from
Nov 30, 2022
Merged

Oven fix mobile #18

merged 9 commits into from
Nov 30, 2022

Conversation

Zott820
Copy link
Collaborator

@Zott820 Zott820 commented Nov 29, 2022 •
edited by fernjager
Loading

  1. Added ability to open oven door fully by tapping/clicking twice within 2 seconds. Workaround for Can't open oven beyond peek on mobile #17
  2. Updated to CreateJS version 1.0. This fixes sound looping on Firefox.
  3. CreateJS version 1.0 broke the sort order for the button to remove the turkey from the oven. Added new alpha for this button to prevent pressing button until oven is open.
  4. Added new dialogue for when the oven light switch is pressed, but the light bulb was not purchased. Enhancement Oven Light - Add Dialogue for "Broken" Oven Light. #10

Please test and review. Thank You!

EDIT by @fernjager: Added the Fixes keywords linking to the relevant GH issues so that they'll be automatically closed once this PR is merged 👍

Fixes #17
Fixes #10

@Zott820
Initial Try
6a7d3af 
No dice! Now the interface is even LESS responsive to Mobile.
@Zott820
Update main.js
3cd1915 
Fixed typo?
@Zott820
Oven Door mechanics Rewrite
5109bf8 
Give up on the touch interfaces.

Allow mobile users and desktop users to open the open fully by clicking to peek, then within 2 seconds, clicking on the handle again.
@Zott820
BugNotes
605e103 
2 Bugs with newest code:
1) Buying turkey when oven open prevents taking oven out or closing oven
2) Can Click on turkey to end game during any oven open state.
@Zott820
Update ui.js
a93a791
@Zott820
Update ui.js
d834ecd 
finalButton variable is created to only allow taking turkey out of oven when oven door is open.

Create JS v1.0 seems to treat the stacking order differently, so the oven door's alpha doesn't prevent clicking the final button with any oven alpha state.
@Zott820
Update main.js
2c7e068 
Clean-up unused comments.
@Zott820
Update ui.js
21263e5 
Fixed missing button breaking sounds.
@fernjager fernjager self-assigned this Nov 29, 2022
@fernjager fernjager self-requested a review November 29, 2022 04:52
@fernjager fernjager assigned Zott820 and unassigned fernjager Nov 29, 2022
fernjager
fernjager requested changes Nov 29, 2022
View reviewed changes
Copy link
Owner

@fernjager fernjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfixes, looks great- just a few small things!

js/ui.js Outdated Show resolved Hide resolved
js/ui.js Outdated Show resolved Hide resolved
js/ui.js Outdated Show resolved Hide resolved
fernjager
fernjager approved these changes Nov 30, 2022
View reviewed changes
Copy link
Owner

@fernjager fernjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!!

@fernjager fernjager merged commit b281490 into master Nov 30, 2022
@fernjager fernjager deleted the OvenFixMobile branch November 30, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernjager fernjager fernjager approved these changes

Assignees

@Zott820 Zott820

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't open oven beyond peek on mobile Oven Light - Add Dialogue for "Broken" Oven Light.
2 participants
@Zott820 @fernjager