Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(java): public constructors in sdk and model #4535

Merged
merged 11 commits into from
Sep 5, 2024
Merged

feat(java): public constructors in sdk and model #4535

merged 11 commits into from
Sep 5, 2024

Conversation

dcb6
Copy link
Contributor

@dcb6 dcb6 commented Sep 4, 2024 •
edited
Loading

Public constructors can now be generated for all model types in both sdk and model:

generators:
   ....
    config:
      enable-public-constructors: true # default false

This was previously only enabled for spring.

@dcb6 dcb6 marked this pull request as ready for review September 4, 2024 21:24
@dcb6 dcb6 requested a review from dsinghvi as a code owner September 4, 2024 21:24
@dsinghvi dsinghvi merged commit 5c5d8ee into main Sep 5, 2024
35 checks passed
@dsinghvi dsinghvi deleted the burke/fer-2827-mavenagi-java-generator-does-not-respect-enable-public branch September 5, 2024 02:34
dcb6 added a commit that referenced this pull request Sep 5, 2024
@dcb6
Revert "feat(java): public constructors in sdk and model (#4535)"
158633e 
This reverts commit 5c5d8ee.
dcb6 added a commit that referenced this pull request Sep 5, 2024
@dcb6
feat(java): revert public constructors in sdk and model (#4554)
16053fc 
* Revert "feat(java): public constructors in sdk and model (#4535)"

This reverts commit 5c5d8ee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcb6 @dsinghvi