Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5D tensor support and tensor dim. test #863

Closed
wants to merge 1 commit into from

Conversation

Zhack47
Copy link
Contributor

@Zhack47 Zhack47 commented Apr 22, 2022

Adds support for 5D tensors #203.

Description

Adding support for 5D tensors as input to a torchio.ScalarImage

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@Zhack47 Zhack47 force-pushed the 203-add-support-for-5d-tensors branch from 2e3e53f to 53b6c5c Compare April 22, 2022 13:57
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #863 (53b6c5c) into main (2972958) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   93.82%   93.77%   -0.06%     
==========================================
  Files          72       72              
  Lines        4535     4546      +11     
==========================================
+ Hits         4255     4263       +8     
- Misses        280      283       +3     
Impacted Files Coverage Δ
torchio/data/image.py 87.90% <100.00%> (+0.26%) ⬆️
torchio/data/subject.py 94.79% <0.00%> (-2.12%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fepegar
Copy link
Owner

fepegar commented May 15, 2022

Hi, @Zhack47. Thanks for the PR. Please, next time discuss it in an issue first.

The new tests don't cover 5D inputs, as transforms are never really applied. I'm going to close this as, for now, support for 5D inputs is not planned.

@fepegar fepegar closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants