-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to pass shape and affine to Resample #640
Conversation
@romainVala Can you try your snippet in #638 and see if this is better? |
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=======================================
Coverage 96.85% 96.86%
=======================================
Files 126 126
Lines 6517 6564 +47
=======================================
+ Hits 6312 6358 +46
- Misses 205 206 +1
Continue to review full report at Codecov.
|
just get a quick look ! great job, i'll look more to better understand, but difficult to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Thanks for reporting and reviewing, @romainVala! |
Fixes #638.
Checklist
CONTRIBUTING
docs and have a developer setup (especially important arepre-commit
andpytest
)pytest
make html
inside thedocs/
folder