Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove internal self.fill, and keep padding_mode as string or number #378

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

romainVala
Copy link
Contributor

@romainVala romainVala commented Dec 11, 2020

Fixes #376.

Description

I remove internal fill attribute, to keep padding_mode as given in input (a string, or a number for the constant mode)
parse_padding_mode was then only use to check padding_mode strings, I rename it to
check_padding_mode

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@fepegar
Copy link
Owner

fepegar commented Dec 11, 2020

Awesome. I added a test that fails on the master branch. Thanks, @romainVala!

@fepegar fepegar merged commit 7293051 into fepegar:master Dec 11, 2020
@romainVala
Copy link
Contributor Author

great, first try was good !
happy to participate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaN appear in Padding, when using history
2 participants