Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TDD] Kata - FooBarQix #121

Merged
merged 3 commits into from
Oct 30, 2020
Merged

[TDD] Kata - FooBarQix #121

merged 3 commits into from
Oct 30, 2020

Conversation

liun03
Copy link
Collaborator

@liun03 liun03 commented Oct 27, 2020 •
edited
Loading

  • I have written unit test first, make it red(fail first).
  • I have then written logic code, make it green(success)
  • I have tried to refactor my code, make it understandable(document my code)

fengyuanyang
fengyuanyang approved these changes Oct 28, 2020
View reviewed changes
Copy link
Owner

@fengyuanyang fengyuanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear and good!!

@fengyuanyang fengyuanyang linked an issue Oct 28, 2020 that may be closed by this pull request
[TDD] Kata - FooBarQix #96
Closed
3 tasks
@fengyuanyang
Copy link
Owner

It would be a nice sample code for others, thanks for your effort.

@fengyuanyang fengyuanyang reopened this Oct 30, 2020
@fengyuanyang fengyuanyang merged commit 2fe44b1 into main Oct 30, 2020
@fengyuanyang fengyuanyang added the hacktoberfest-accepted welcome to hacktoberfest- accepted label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengyuanyang fengyuanyang fengyuanyang approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted welcome to hacktoberfest- accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TDD] Kata - FooBarQix
2 participants
@liun03 @fengyuanyang