issue-132: increase coverage on LinkedListNodeTest

fengyuanyang · Mar 1, 2021 · d1f9767 · d1f9767
1 parent 8ff455b
commit d1f9767
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/src/main/java/com/ordestiny/tdd/interview/linkedlist/LinkedListNode.java b/src/main/java/com/ordestiny/tdd/interview/linkedlist/LinkedListNode.java
@@ -11,15 +11,8 @@ public boolean hasNext() {
  return next != null;
  }
 
- public void setNext(LinkedListNode<E> next) {
- this.next = next;
- }
-
  public E getData() {
  return data;
  }
 
- public void setData(E data) {
- this.data = data;
- }
 }
diff --git a/src/main/java/com/ordestiny/tdd/interview/linkedlist/LinkedListNodeUtil.java b/src/main/java/com/ordestiny/tdd/interview/linkedlist/LinkedListNodeUtil.java
@@ -41,8 +41,7 @@ public static LinkedListNode partition(LinkedListNode node , int x) {
  return rightNodeHead;
  if (rightNodeHead == null)
  return leftNodeHead;
- if (rightNodeHead != null)
- leftCurrentNode.next = rightNodeHead;
+ leftCurrentNode.next = rightNodeHead;
 
  return leftNodeHead;
  }

diff --git a/src/test/java/com/ordestiny/tdd/interview/linkedlist/LinkedListNodeUtilTest.java b/src/test/java/com/ordestiny/tdd/interview/linkedlist/LinkedListNodeUtilTest.java
@@ -1,18 +1,20 @@
 package com.ordestiny.tdd.interview.linkedlist;
 
 import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 
 import java.util.stream.Stream;
 
 public class LinkedListNodeUtilTest {
+ LinkedListNodeUtil util = new LinkedListNodeUtil();
 
  @ParameterizedTest
  @MethodSource("partitionArguments")
  void partition(LinkedListNode<Integer> node, int x, LinkedListNode<Integer> expectedNode) {
- LinkedListNode<Integer> currentNode = LinkedListNodeUtil.partition(node, x);
+ LinkedListNode<Integer> currentNode = util.partition(node, x);
 
  do {
  Assertions.assertEquals(expectedNode.getData(), currentNode.getData());
@@ -24,11 +26,20 @@ void partition(LinkedListNode<Integer> node, int x, LinkedListNode<Integer> expe
  } while (currentNode.hasNext());
  }
 
+ @Test
+ void partition_withNullNode_() {
+ LinkedListNode<Integer> currentNode = util.partition(null, 5);
+
+ Assertions.assertEquals(null, currentNode);
+ }
+
  private static Stream<Arguments> partitionArguments() {
  return Stream.of(
  Arguments.of(generate(3, 5, 8, 5, 10, 2, 1), 5, generate(3, 2, 1, 5, 8, 5, 10)),
  Arguments.of(generate(3, 11, 20, 7, 9, 10), 9, generate(3, 7, 11, 20, 9, 10)),
- Arguments.of(generate(20, 19, 23, 13, 6, 5, 0), 0, generate(20, 19, 23, 13, 6, 5, 0))
+ Arguments.of(generate(20, 19, 23, 13, 6, 5, 0), 0, generate(20, 19, 23, 13, 6, 5, 0)),
+ Arguments.of(generate(20, 19, 23, 13, 6, 5, 0), 25, generate(20, 19, 23, 13, 6, 5, 0)),
+ Arguments.of(generate(20), 22, generate(20))
  );
  }