Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:to fixed ToolbarOption is undenfined #473

Merged
merged 1 commit into from
May 29, 2021

Conversation

chenlang0311
Copy link
Contributor

@chenlang0311 chenlang0311 commented May 22, 2021

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #473 (31276b5) into master (394c3f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files           8        8           
  Lines        1419     1419           
=======================================
  Hits         1077     1077           
  Misses        342      342           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394c3f1...31276b5. Read the comment docs.

@chenlang0311
Copy link
Contributor Author

chenlang0311 commented May 22, 2021

使用最新版本1.9.1.当项目中使用了TS的时候,打包的时候会报错,错误如图
image

@fengyuanchen
Copy link
Owner

What's your configure for the Viewer class?

@chenlang0311
Copy link
Contributor Author

chenlang0311 commented May 24, 2021

What's your configure for the Viewer class?

No other options, the options is the defaut, you can see the v-viewer, we are use the package.

new Viewer(el, { inline: false, filter: filterImage, url: filterSrc })
function filterImage(image) {
  return image.getAttribute('data-viewer');
}
function filterSrc(image) {
  return image.getAttribute('data-src');
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants