Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility With SherlockActionBar #34

Open
patelakshay13890 opened this issue Dec 17, 2014 · 18 comments
Open

Compatibility With SherlockActionBar #34

patelakshay13890 opened this issue Dec 17, 2014 · 18 comments

Comments

@patelakshay13890
Copy link

Can we use these Lib. im my sample app. that uses SherlockActionBar ?
expecting +ve rply...

@fengdai
Copy link
Owner

fengdai commented Dec 17, 2014

Of course you can. Any problem?

@patelakshay13890
Copy link
Author

yes i do having problem..
bcoz conflicting theme may be..
do u have any example related that ?
bcoz i do req. to use these theme in app...
expecting +ve response...

On Wed, Dec 17, 2014 at 5:37 PM, Feng Dai [email protected] wrote:

Of course you can. Any problem?


Reply to this email directly or view it on GitHub
#34 (comment)
.

@fengdai
Copy link
Owner

fengdai commented Dec 18, 2014

I don't have an example about that now. Can you tell me how you combined this library with Sherlock? What is the detailed error info?

@patelakshay13890
Copy link
Author

Can you plz provide sample ??

On Thu, Dec 18, 2014 at 10:49 AM, Feng Dai [email protected] wrote:

I don't have an example about that now. Can you tell me how you combined
this library with Sherlock? What is the detailed error info?


Reply to this email directly or view it on GitHub
#34 (comment)
.

@fengdai
Copy link
Owner

fengdai commented Dec 18, 2014

I'll provide it ASAP.

@patelakshay13890
Copy link
Author

okkk...
Expecting answer...!!

On Thu, Dec 18, 2014 at 1:55 PM, Feng Dai [email protected] wrote:

I'll provide it ASAP.


Reply to this email directly or view it on GitHub
#34 (comment)
.

@fengdai
Copy link
Owner

fengdai commented Dec 19, 2014

I tried. Then I found that it can't be compiled with error:

"Error:Attribute "xxx" has already been defined". 

That's because AlertDialogPro uses official AppCompat-v7 whose some defined attributes' names are the same as ActionBarSherlock's. I am trying to resolve it.

I just have a question. Why don't you use AppCompat-v7 instead of Sherlock? It can provide you a Material Design Action Bar.

@patelakshay13890
Copy link
Author

I know that but i want to use both Lib. ABS & your AlertDialogue lib...
So is it possible ?

On Fri, Dec 19, 2014 at 7:20 AM, Feng Dai [email protected] wrote:

I tried. Then I found that it can't be compiled with error:

"Error:Attribute "xxx" has already been defined".

That's because AlertDialogPro uses official AppCompat-v7 whose some
defined attributes' names are the same as ActionBarSherlock's. I am trying
to resolve it.

I just have a question. Why don't you use AppCompat-v7 instead of
Sherlock? It can provide you a Material Design Action Bar.


Reply to this email directly or view it on GitHub
#34 (comment)
.

@fengdai
Copy link
Owner

fengdai commented Dec 19, 2014

My AlertDialogPro lib is based on Google's ActionBarCompat. Since you can't use ABS and Google's ActionBarCompat together. So I think it's difficult to use both ABS & my AlertDialogPro...

BTW. If you develop a new app, I suggest you don't use ActionBarSherlock and consider Google's ActionBarCompat as your first choice.

@patelakshay13890
Copy link
Author

thanx for fast rply...
okk...

On Fri, Dec 19, 2014 at 11:32 AM, Feng Dai [email protected] wrote:

My AlertDialogPro lib is based on Google's ActionBarCompat. Since you
can't use ABS and Google's ActionBarCompat together
JakeWharton/ActionBarSherlock#999. So I think
it's difficult to use both ABS & my AlertDialogPro...

BTW. If you develop a new app, I suggest you don't use
ActionBarSherlock and consider Google's ActionBarCompat as your first
choice.


Reply to this email directly or view it on GitHub
#34 (comment)
.

@patelakshay13890
Copy link
Author

But in AppCompact it does not show Icon with HomeButton in small as in ABS
thas why i switched to ABS

On Fri, Dec 19, 2014 at 11:49 AM, akshay patel [email protected]
wrote:

thanx for fast rply...
okk...

On Fri, Dec 19, 2014 at 11:32 AM, Feng Dai [email protected]
wrote:

My AlertDialogPro lib is based on Google's ActionBarCompat. Since you
can't use ABS and Google's ActionBarCompat together
JakeWharton/ActionBarSherlock#999. So I
think it's difficult to use both ABS & my AlertDialogPro...

BTW. If you develop a new app, I suggest you don't use
ActionBarSherlock and consider Google's ActionBarCompat as your first
choice.


Reply to this email directly or view it on GitHub
#34 (comment)
.

@fengdai
Copy link
Owner

fengdai commented Dec 19, 2014

What did you mean by "show Icon with HomeButton in small "? And did you use the latest ActionBarCompat?

@patelakshay13890
Copy link
Author

Display difference between two ActionBars...!!!
I want bar like in ABS display with icon
So can you tell me how can i achieve this using AppCompact ??

On Fri, Dec 19, 2014 at 12:05 PM, Feng Dai [email protected] wrote:

What did you mean by "show Icon with HomeButton in small "? And did you
use the latest ActionBarCompat?


Reply to this email directly or view it on GitHub
#34 (comment)
.

@fengdai
Copy link
Owner

fengdai commented Dec 19, 2014

Could you provide a image to show what you want?

@patelakshay13890
Copy link
Author

Same as Image in ABS with Small HomeButton not as an Arrow in AppCompact
bcoz ActionBar Size

On Fri, Dec 19, 2014 at 5:58 PM, Feng Dai [email protected] wrote:

Could you provide a image to show what you want?


Reply to this email directly or view it on GitHub
#34 (comment)
.

@fengdai
Copy link
Owner

fengdai commented Dec 19, 2014

Sorry, still can't imagine that from your description. What is "Small HomeButton"? Is it a logo? You'd better provide a image to show me.

@fengdai
Copy link
Owner

fengdai commented Dec 26, 2014

@patelakshay13890 Jake Wharton has made ActionBarSherlock deprecated several days ago: https://github.com/JakeWharton/ActionBarSherlock
It's time to migrate to AppCompact...

@consp1racy
Copy link

@patelakshay13890 probably did not read Material Design guidelines and doesn't know that the app icon is not automatically shown. Brand should be communicated via distinct color/font or logo instead of title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants