Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: add page home #813

Merged
merged 3 commits into from
Apr 14, 2024
Merged

gui: add page home #813

merged 3 commits into from
Apr 14, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Mar 10, 2024

  1. Renderring daily recommended playlists/songs from all providers in homepage.
  2. fix Failing doctests with 3.12 #821

Add this option to enable new homepage

config.ENABLE_NEW_HOMEPAGE = True

@coveralls
Copy link

coveralls commented Apr 14, 2024

Pull Request Test Coverage Report for Build 8679336961

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 64 of 143 (44.76%) changed or added relevant lines in 11 files are covered.
  • 125 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 54.98%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/uimain/sidebar.py 2 3 66.67%
feeluown/gui/helpers.py 0 3 0.0%
feeluown/gui/uimain/page_view.py 7 13 53.85%
feeluown/gui/pages/homepage.py 20 89 22.47%
Files with Coverage Reduction New Missed Lines %
feeluown/gui/uimain/page_view.py 1 36.52%
feeluown/gui/helpers.py 1 64.01%
feeluown/gui/widgets/mpv_.py 27 37.97%
feeluown/gui/uimain/lyric.py 96 42.14%
Totals Coverage Status
Change from base Build 8218415207: -0.2%
Covered Lines: 9666
Relevant Lines: 17581

💛 - Coveralls

@cosven cosven merged commit ae5910c into feeluown:master Apr 14, 2024
10 checks passed
@cosven cosven deleted the homepage branch April 14, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing doctests with 3.12
2 participants