Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: brand new volume slider #807

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Conversation

cosven
Copy link
Member

@cosven cosven commented Mar 2, 2024

The older volume slider has two problems

  1. UX is not good
  2. drag the slider causes the app hang. Worse,

    正在播放时拖动音量导致界面卡死,xorg 下几乎卡死整个 xserver,wayland 下留一个音量条始终在顶部,主界面被 kwin 标记为灰色,音乐正常播放
    此时 htop 看到所有进程均分 100% CPU(大概是得谢谢 GIL),命令行 fuo status 会卡死
    本次 Syu 的 log https://fars.ee/Ginq 包含 upgraded feeluown (4.0.1-1 -> 4.1-1)

Now, introducing a self-painting slider to solve these problems.
User can use up/down or mouse to adjust the volume.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8120910363

Details

  • 25 of 53 (47.17%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 55.237%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/drawers.py 1 2 50.0%
feeluown/gui/widgets/volume_button.py 24 51 47.06%
Files with Coverage Reduction New Missed Lines %
feeluown/gui/widgets/selfpaint_btn.py 2 49.43%
feeluown/library/library.py 3 71.49%
Totals Coverage Status
Change from base Build 8030202694: -0.07%
Covered Lines: 9055
Relevant Lines: 16393

💛 - Coveralls

@cosven cosven merged commit cc5348e into feeluown:master Mar 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants