Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix several bugs #802

Merged
merged 4 commits into from
Feb 21, 2024
Merged

*: fix several bugs #802

merged 4 commits into from
Feb 21, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Feb 20, 2024

Fix three issues

  1. video does not show on macOS
  2. song is marked as bad even if has mv media
  3. user avatar never shows

@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 7975616227

Details

  • -14 of 19 (26.32%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 55.335%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/components/avatar.py 0 1 0.0%
feeluown/gui/uimain/nowplaying_overlay.py 0 2 0.0%
feeluown/player/playlist.py 4 7 57.14%
feeluown/gui/watch.py 0 4 0.0%
feeluown/library/provider.py 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
feeluown/gui/uimain/nowplaying_overlay.py 1 66.67%
feeluown/gui/watch.py 1 41.84%
Totals Coverage Status
Change from base Build 7974153956: -0.02%
Covered Lines: 9076
Relevant Lines: 16402

💛 - Coveralls

@cosven cosven changed the title *: fix video-show on macos and fix mark-song-as-bad *: fix several bugs Feb 20, 2024
@cosven cosven merged commit 1e73da5 into feeluown:master Feb 21, 2024
10 checks passed
@cosven cosven deleted the video-macos branch February 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants