Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: picture-in-picture mode may cause segfault on wayland environment #798

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Feb 17, 2024

No description provided.

@coveralls
Copy link

coveralls commented Feb 17, 2024

Pull Request Test Coverage Report for Build 7946529143

Details

  • -46 of 68 (32.35%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 55.429%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/player/mpvplayer.py 0 1 0.0%
feeluown/gui/widgets/mpv_.py 7 15 46.67%
feeluown/gui/uimain/nowplaying_overlay.py 6 18 33.33%
feeluown/gui/watch.py 7 32 21.88%
Files with Coverage Reduction New Missed Lines %
feeluown/gui/uimain/nowplaying_overlay.py 1 67.59%
Totals Coverage Status
Change from base Build 7927858520: -0.05%
Covered Lines: 9066
Relevant Lines: 16356

💛 - Coveralls

@cosven cosven closed this Feb 17, 2024
@cosven
Copy link
Member Author

cosven commented Feb 17, 2024

@cosven 这个方案并不行 ~

@cosven cosven reopened this Feb 18, 2024
@cosven cosven merged commit 82c4b94 into feeluown:master Feb 18, 2024
19 checks passed
@cosven cosven deleted the fix-pip-mode branch February 18, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants