Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: introduce ClickableMixin #787

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

cosven
Copy link
Member

@cosven cosven commented Jan 28, 2024

  1. click the accordion header can fold/unfold contents
  2. click the cover label to show/hide nowplaying overlay (demo)
  • add unittest

1. click the accordion header can fold/unfold contents
2. click the cover label to show/hide nowplaying overlay (demo)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7687171277

  • -31 of 72 (56.94%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 55.148%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/uimain/player_bar.py 7 9 77.78%
feeluown/gui/uimain/nowplaying_overlay.py 16 22 72.73%
feeluown/gui/widgets/accordion.py 3 9 33.33%
feeluown/gui/helpers.py 12 29 41.38%
Files with Coverage Reduction New Missed Lines %
feeluown/gui/widgets/accordion.py 1 29.27%
Totals Coverage Status
Change from base Build 7678294412: 0.008%
Covered Lines: 8635
Relevant Lines: 15658

💛 - Coveralls

@cosven cosven merged commit d16025c into feeluown:master Jan 29, 2024
10 checks passed
@cosven cosven deleted the clickable-label branch January 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants