Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player,gui: much better lyrics support #680

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

cosven
Copy link
Member

@cosven cosven commented Apr 20, 2023

  1. support translated lyrics
  2. save and restore lyric window settings, including font, bg, fg, geometry
  3. auto-scoll lyric view

image
image

1. support translated lyrics
2. save and restore lyric window settings, including font, bg, fg,
   geometry
@coveralls
Copy link

coveralls commented Apr 20, 2023

Pull Request Test Coverage Report for Build 4763565496

  • 235 of 413 (56.9%) changed or added relevant lines in 14 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 61.52%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/uimain/player_bar.py 1 2 50.0%
feeluown/gui/widgets/magicbox.py 0 4 0.0%
feeluown/gui/tips.py 8 13 61.54%
feeluown/player/lyric.py 79 84 94.05%
feeluown/app/app.py 14 20 70.0%
feeluown/app/gui_app.py 2 9 22.22%
feeluown/gui/pages/song_explore.py 10 17 58.82%
feeluown/gui/widgets/lyric.py 18 44 40.91%
feeluown/gui/uimain/lyric.py 95 212 44.81%
Files with Coverage Reduction New Missed Lines %
feeluown/player/mpvplayer.py 3 60.87%
feeluown/gui/pages/song_explore.py 8 78.51%
Totals Coverage Status
Change from base Build 4753079158: -0.09%
Covered Lines: 8216
Relevant Lines: 13355

💛 - Coveralls

@cosven cosven merged commit 92c9487 into feeluown:master Apr 21, 2023
@cosven cosven deleted the lyric branch April 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants