Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nowplaying: support macos #674

Merged
merged 13 commits into from
Apr 19, 2023
Merged

nowplaying: support macos #674

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8a6c140
nowplaying: support macos
cosven Apr 19, 2023
f641d93
add pylint
cosven Apr 19, 2023
4754808
ci: install platform specific deps
cosven Apr 19, 2023
895bf64
use patched aionowplaying
cosven Apr 19, 2023
a43710c
ignore import-error
cosven Apr 19, 2023
4b246d4
disable failfast
cosven Apr 19, 2023
1a075fc
tune pylint
cosven Apr 19, 2023
2f72427
adjust integration-tests
cosven Apr 19, 2023
ac85d1e
refine naming
cosven Apr 19, 2023
ece632c
set QT_EVENT_DISPATCHER_CORE_FOUNDATION=1 by defautl
cosven Apr 19, 2023
9a883d2
refine shutdown msg
cosven Apr 19, 2023
a8d6baa
newline
cosven Apr 19, 2023
aacc9c6
verbose log in integration test
cosven Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set QT_EVENT_DISPATCHER_CORE_FOUNDATION=1 by defautl
  • Loading branch information
@cosven
cosven committed Apr 19, 2023
commit ece632c5b34807bc1185e2cbb1da45d83b609dbd
6 changes: 5 additions & 1 deletion feeluown/entry_points/run_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,13 @@ def before_start_app(args):
# Run.
#
if AppMode.gui in AppMode(config.MODE):
# Enable auto scale by default so that it can work well with HiDPI display.
if sys.platform == 'win32':
# Enable auto scale by default so that it can work well with HiDPI display.
os.environ.setdefault('QT_AUTO_SCREEN_SCALE_FACTOR', '1')
elif sys.platform == 'darwin':
# Use native event loop on macOS, so that some native service such as
# nowplaying can work.
os.environ.setdefault('QT_EVENT_DISPATCHER_CORE_FOUNDATION', '1')
try:
# HELP: QtWebEngineWidgets must be imported before a
# QCoreApplication instance is created.
Expand Down