[podcast] Fix Duration and Play Button #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two bugs within the Podcast player. It could happen that the play time and remaining time was not shown correctly in the player. This mainly occured in Safari and is now fixed by not using a regular expression to show the time, but instead we have added a new "_printDuration" function which handles the formatting of the durations. Not only, but mainly on Safari it could also happen, that once a Podcast was started and then paused, the loading spinner was displayed and a user could not continue with the Podcast. This is now fixed, by removing the spinner and only show the play, pause or replay button. As loading indication we are now only using the seek bar. Last but not least this commit also improves the readability of the code, for parsing the icon of a Podcast feed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two bugs within the Podcast player.
It could happen that the play time and remaining time was not shown correctly in the player. This mainly occured in Safari and is now fixed by not using a regular expression to show the time, but instead we have added a new "_printDuration" function which handles the formatting of the durations.
Not only, but mainly on Safari it could also happen, that once a Podcast was started and then paused, the loading spinner was displayed and a user could not continue with the Podcast. This is now fixed, by removing the spinner and only show the play, pause or replay button. As loading indication we are now only using the seek bar.
Last but not least this commit also improves the readability of the code, for parsing the icon of a Podcast feed.