Label alignment and icon #1058
Open
Label alignment and icon #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix of addling listener to Event.REMOVED_FROM_STAGE in DefaultPopUpManager:addPopUp
…er overriding in subclasses
…ME_* with DEFAULT_CHILD_STYLE_NAME_*. better matches the changeover to styleNameList from nameList. old properties are deprecated and will be removed in the future.
…ME_* with DEFAULT_CHILD_STYLE_NAME_*, replaced ALTERNATE_NAME_ with ALTERNATE_STYLE_NAME_. better matches the changeover to styleNameList from nameList. old properties are deprecated and will be removed in the future.
…instead of the old 'name' naming convention)
…on of desktop themes
… compiler bug (closes #1000)
… with doNothing() function
…een() and clearScreen(), pass transition to clearScreenInternal() instead of boolean
… on screens (closes #992)
…the component initializes. updated docs to explain that the old properties will not be reset in any way.
…n property (closes #995)
…eep scrolling smooth when items unexpectedly resize (references #432)
… adjust scroll position to avoid jumpy or shifting items when scrolling backgrounds while the layout is virtual with variable item dimensions (closes #432)
…n view port bounds are infinite (references #1007)
…ildren as a pop-up wouldn't properly set the focus manager on the children (closes #999)
…esult in the style provider being reapplied (closes #1006)
…ort would result in being unable to scroll (closes #1007)
…to constructor was ignored (closes #1009)
…ight and maxWidth/Height into account for proper measurement
…ly dispatched on disposal because dataProvider is set to null
…spatch an extra Event.CHANGE on dispose
…s into custom header factory as a best practice
…ound showing things that they shouldn't
…n empty space with a color because the transparency was distracting
…ng different types of transitions wouldn't work anyway. the screen navigator enforces the rule that only one transition may be active at a time anyway
…nd for the issue where the first few frames of a transition can be skipped. the full animation is now visible even on slow mobile devices.
…ence links that were lost in the conversion
… special icons, style tweaks to aside elements
…e old wiki format didn't support in certain elements
…ggleButton, and ButtonGroup
…nversion from wiki
…ut, and custom layouts
… minor edits here and there to fix issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Josh,
I've been working to add some alignment and icon from Label, this is something i often need from my projects and i guess it avoid some hard work using LayoutGroup.
I tried to match as best as possible your code style but in case you can't merge it i'll be glad if this may help in any way.
Thank you!