Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Haxe 3.3.0] Support of --wait stdio #1409

Closed
wants to merge 2 commits into from

Conversation

SlavaRa
Copy link

@SlavaRa SlavaRa commented Nov 28, 2016

@Neverbirth
Copy link
Contributor

Neverbirth commented Nov 28, 2016

This should be configurable, because keeping the old method of working is useful for getting compile information (EDIT: you open a haxe server with verbose compile information, connect to it in FD, and wait for each compile to get the info) and in some minor cases to reuse the same haxe instance.

@SlavaRa
Copy link
Author

SlavaRa commented Nov 28, 2016

Okey.
Enable stdtio with false by default or Disable stdio with false by default or another variant?

@Neverbirth
Copy link
Contributor

I'd go with the first one because it's the classical behavior, but I don't care that much really. It would be more for @elsassph and @Meychi to decide maybe.

@elsassph
Copy link
Member

We're still using Haxe 3.1.3 here; backward compatibility is important. You should be able to get the compiler version I think.

@elsassph
Copy link
Member

And it should probably be possible to disable it in general (who knows what problems people can run into - we also need to disable the compiler server)

@elsassph
Copy link
Member

That's very cool though!

@SlavaRa
Copy link
Author

SlavaRa commented Nov 29, 2016

@elsassph Enable stdtio with false by default or Disable stdio with false by default or another variant?

@Neverbirth
Copy link
Contributor

@elsassph Unless I miss something backwards compatibility is already kept. And since this is using the compiler server, it can be disabled in the same way as the old server.

@elsassph
Copy link
Member

I'd enable by default (bool prop to disable it so default value is false) if you properly detect that it is supported by the compiler.

@SlavaRa
Copy link
Author

SlavaRa commented Nov 30, 2016

I added the setting

@Neverbirth
Copy link
Contributor

Will review today (hope not to forget!), but if someone else reviews and merge before than I do I'm OK with it.

@SlavaRa
Copy link
Author

SlavaRa commented Nov 30, 2016

@Neverbirth thanks

@@ -6112,4 +6112,8 @@ AND - All conditions are met.</value>
<value>Defines which method should be used to clean the contents of the output panel.</value>
<comment>Added after 5.2.0</comment>
</data>
<data name="HaXeContext.Description.CompletionServerWaitStdio" xml:space="preserve">
<value>Makes haxe completion server use stdin and stderr instead of sockets for communication with IDE. (only applies to CompletionServer Completion Mode).</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that my English is perfect, but I'd say:

Makes Haxe completion server to use stdin and stderr instead of sockets for communication with the IDE (only applies to CompletionServer Completion Mode and Haxe 3.3+).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will fix it today

@Neverbirth
Copy link
Contributor

Neverbirth commented Nov 30, 2016

Is this PR really complete? From what I read of this new mode it looks like it isn't. CompletionServerCompletionHandler still behaves the same way, so it's using TCPClient to send queries instead of stdin, and haxeProcess_ErrorDataReceived should be changed to read the compiler results. Isn't it like this?

@SlavaRa SlavaRa closed this Dec 1, 2016
@Neverbirth
Copy link
Contributor

So what's the plan on this?

@SlavaRa
Copy link
Author

SlavaRa commented Dec 2, 2016

I rediscovered PR today or tomorrow

@SlavaRa SlavaRa deleted the feature/wait_stdio branch October 27, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants