Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRV-525 select with default #179

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Conversation

fireridlle
Copy link
Contributor

@fireridlle fireridlle commented Mar 2, 2021

Notes

In the python driver, Select() does not accept the 3rd default parameter.
It would be better if we didn't have to use select_with_default() - as this isn't very intuitive and not according to the Docs.

Jira ticket

DRV-525

@parkhomenko
Copy link
Contributor

parkhomenko commented Mar 2, 2021

Does it make sense to add
@deprecated("use select instead.") above the select_with_default method?

@erickpintor
Copy link
Contributor

Does it make sense to add
@deprecated("use select instead.") above the select_with_default method?

I think it does. select_with_default it not part of most drivers. I don't see a reason to deviate from just select right now.

Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fireridlle fireridlle merged commit e557c07 into master Mar 31, 2021
@cleve-fauna cleve-fauna deleted the fix/DRV-525_select_with_default branch February 11, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants