Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code coverage badge #106

Merged
merged 1 commit into from
Nov 2, 2016
Merged

fix code coverage badge #106

merged 1 commit into from
Nov 2, 2016

Conversation

marrony
Copy link
Contributor

@marrony marrony commented Nov 2, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 2, 2016

Current coverage is 98.27% (diff: 100%)

Merging #106 into master will not change coverage

@@             master       #106   diff @@
==========================================
  Files             9          9          
  Lines           464        464          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            456        456          
  Misses            8          8          
  Partials          0          0          

Powered by Codecov. Last update 539c68e...4c37abb

@@ -7,7 +7,7 @@ WIP
This driver is under development. Changes may happen until we have an official release

.. image:: https://img.shields.io/travis/faunadb/faunadb-python/master.svg?maxAge=21600 :target: https://travis-ci.org/faunadb/faunadb-python
.. image:: https://img.shields.io/coveralls/faunadb/faunadb-python/master.svg?maxAge=21600 :target: https://coveralls.io/github/faunadb/faunadb-python?branch=master
.. image:: https://codecov.io/gh/faunadb/faunadb-python/branch/master/graph/badge.svg :target: https://codecov.io/gh/faunadb/faunadb-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image link is good, but for some reason it's a broken image link in the rendered view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, I just copied from codecov

@marrony marrony force-pushed the codecov-badge branch 4 times, most recently from 37ce802 to ce6bd91 Compare November 2, 2016 20:13
Copy link
Contributor

@ashfire908 ashfire908 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just go ahead with this now and hope whatever caching issue that's going on resolves itself.

@marrony marrony merged commit 397d587 into master Nov 2, 2016
@marrony marrony deleted the codecov-badge branch November 2, 2016 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants