Nuget setup #9
Merged
Nuget setup #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| See https://faunadb.com for more information.</description> | ||
| <licenseUrl>https://github.com/faunadb/faunadb-csharp/blob/master/LICENSE</licenseUrl> | ||
| <projectUrl>https://faunadb.com/</projectUrl> |
There was a problem hiding this comment.
Shouldn't the projectUrl be the github url?
|
lgtm |
| @@ -28,7 +28,7 @@ First install the Nuget package by editing your `packages.config` | |||
| ```xml | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="FaunaDB" version="1.0.0" targetFramework="net45" /> | |||
| <package id="FaunaDB.Client" version="0.0.1" targetFramework="net45" /> | |||
There was a problem hiding this comment.
shouldn't this be 0.1.0, not 0.0.1
|
🐑 it! |
| @@ -0,0 +1,3 @@ | |||
| Remove-Item packages\FaunaDB.Client -Recurse -Force | |||
| Make-Item packages\FaunaDB.Client | |||
There was a problem hiding this comment.
New-Item -ItemType directory iirc
There was a problem hiding this comment.
yeap, now it's tested on windows
|
Is there anything missing here? Can we ship it and release C#? |
|
Nothing that I'm aware of |
|
@ed Is this PR ok for you? |
|
Yeah this is good |
|
ship |
parkhomenko
pushed a commit
that referenced
this pull request
Oct 22, 2021
Changed query constructors to use varargs where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.