Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# documentation #7

Closed
wants to merge 18 commits into from
Closed

C# documentation #7

wants to merge 18 commits into from

Conversation

marrony
Copy link
Contributor

@marrony marrony commented Jul 22, 2016

No description provided.

@marrony marrony force-pushed the csharp_documentation branch 2 times, most recently from fc4eef4 to 4f09fff Compare July 29, 2016 20:05
/// </summary>
/// <example>
/// <code language="cs">
/// var client = new Client(secret: "someAuthToken");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Client/FaunaClient/

IResult<IReadOnlyList<Value>> data = result.At("data").To(Codec.ARRAY);
```

Fourth is how work with `IResult<T>` objects. This object represents the result of an operation and it might be success or a failure. All operations on `Codec` return an object like this. This is this way so you don't need to check for nullability everywhere.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/This is this way so you don't/This way you don't/

@erickpintor
Copy link
Contributor

I'm done with my first pass. Let us know once we can review it again.

@marrony
Copy link
Contributor Author

marrony commented Aug 1, 2016

The first changes are done. It's ready to another pass of review

@erickpintor
Copy link
Contributor

Looks good to me.
🐑 it!

@erickpintor
Copy link
Contributor

Can you change the target to master? I forgot to merge this before the other PR.

@marrony
Copy link
Contributor Author

marrony commented Aug 1, 2016

How can I do this?

@erickpintor
Copy link
Contributor

git branch --set-upstream or something like that, if I recall correctly.

@marrony
Copy link
Contributor Author

marrony commented Aug 1, 2016

I searched on internet and there's no way to change base/target branch from a PR, at least for now.

@marrony marrony closed this Aug 1, 2016
@erickpintor erickpintor deleted the csharp_documentation branch August 1, 2016 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants