Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoder cast among Values type #45

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Fix decoder cast among Values type #45

merged 1 commit into from
Apr 13, 2017

Conversation

marrony
Copy link
Contributor

@marrony marrony commented Apr 13, 2017

This fix the case when we want to decode a StringV to a Value for example, since StringV extends Value we could just assign the string, but instead it was trying to instantiate a Value.

@marrony
Copy link
Contributor Author

marrony commented Apr 13, 2017

Need this reviewed before #43

erickpintor
erickpintor approved these changes Apr 13, 2017
View reviewed changes
Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Interesting. I had to do the same thing for Go lang driver.

@marrony marrony merged commit 22127c4 into faunadb-csharp-1.0 Apr 13, 2017
@marrony marrony deleted the fix-decoder-cast branch April 13, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickpintor erickpintor erickpintor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marrony @erickpintor