Make C# driver look likes Java driver #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make use of Expr class in every place a expression is needed * make lambdas instrospection to get parameter names
marrony
force-pushed
the
csharp_driver_vs
branch
from
53b33a7
to
593afc0
Compare
|
As far I could research, C# only has one single |
|
You'd still be able to share the connection... Not a big deal now, but more so w/ HTTP 2 or some other more persistent connection protocol. |
|
yes, also the documentation of |
|
This is looking good to me. |
| /// <param name="port">Port of the FaunaDB server.</param> | ||
| /// <param name="timeout">Timeout. Defaults to 1 minute.</param> | ||
| /// <param name="secret">Auth token for the FaunaDB server.</param> | ||
| /// <param name="clientIO">Optional IInnerClient. Used only for testing.</param>"> |
marrony
force-pushed
the
csharp_driver_vs
branch
from
a6c7028
to
2140f40
Compare
|
I'm waiting for @matt to sign this off. We can ship it, IMO. |
|
🐑 it |
evbruno
pushed a commit
that referenced
this pull request
Mar 31, 2020
parkhomenko
pushed a commit
that referenced
this pull request
Oct 22, 2021
Don't wrap Set json in {"@set": }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is ready to validate, however I don't finished the code documentation yet.
To review the code on Mac you can install Xamarin Studio
brew cask install xamarin-studioIt's possible to run the tests directly on Xamarin, but it may be necessary to install Mono
brew install mono