Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change KeyFromSecret argument to Expr + simplify test #28

Merged
merged 1 commit into from
Feb 3, 2017
Merged

change KeyFromSecret argument to Expr + simplify test #28

merged 1 commit into from
Feb 3, 2017

Conversation

marrony
Copy link
Contributor

@marrony marrony commented Feb 2, 2017 •
edited
Loading

ashfire908
ashfire908 approved these changes Feb 2, 2017
View reviewed changes
Copy link
Contributor

@ashfire908 ashfire908 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrony marrony merged commit d6d2f6f into master Feb 3, 2017
@marrony marrony deleted the fix_key_from_secret branch February 3, 2017 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfire908 ashfire908 ashfire908 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marrony @ashfire908