ENG-3044: Introduce set streaming support #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleve-fauna
force-pushed
the
set-streaming-support
branch
from
504a352
to
b9bed55
Compare
adambollen
reviewed
Feb 8, 2022
| @@ -53,6 +50,7 @@ commands: | |||
| - run: | |||
| name: Run Tests 5.0 | |||
| command: | | |||
| apt-get install -y dotnet-sdk-5.0 | |||
There was a problem hiding this comment.
There's also a version 5 SDK image available, so you could remove this line and put this on line 12 above:
- image: mcr.microsoft.com/dotnet/sdk:5.0
There was a problem hiding this comment.
Since this passes, it's probably not necessary, just another option.
There was a problem hiding this comment.
Ah cool, was thinking maybe we keep it as is and start running tests on dotnet 6.
henryfauna
previously approved these changes
Feb 8, 2022
cleve-fauna
force-pushed
the
set-streaming-support
branch
from
427f9be
to
b9bed55
Compare
henryfauna
approved these changes
Feb 8, 2022
cleve-fauna
added a commit
that referenced
this pull request
Feb 8, 2022
* introduce set streaming support * Fix circleci config - test dotnet 5.0 correctly, use public FaunaDB image Co-authored-by: Cleve Stuart <[email protected]>
Merged
macnealefauna
pushed a commit
that referenced
this pull request
Feb 8, 2022
* OSS-775: Create docs for C# driver (#166) * ENG-3044: Introduce set streaming support (#184) * introduce set streaming support * Fix circleci config - test dotnet 5.0 correctly, use public FaunaDB image Co-authored-by: Cleve Stuart <[email protected]> Co-authored-by: shestakovg <[email protected]> Co-authored-by: Erick Pintor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: