WIP #1
Closed
WIP #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var res = Array.IndexOf(lines, " Response JSON:"); | ||
| Assert.That(res != -1); | ||
| Assert.AreEqual(" {", lines[res + 1]); |
There was a problem hiding this comment.
these asserts need to be line-ending agnostic
andy-faunadb
force-pushed
the
wip
branch
6 times, most recently
from
89fe9b9
to
8aed545
Compare
andy-faunadb
force-pushed
the
wip
branch
3 times, most recently
from
125be74
to
3968f3a
Compare
|
Hi team! I'm adding some comments inline but please, keep in mind that I have no professional experience in C# at all. I'm just trying to confirm my understanding and hopefully trigger some interesting discussions. |
andy-faunadb
force-pushed
the
wip
branch
5 times, most recently
from
259ff95
to
97f91e0
Compare
andy-faunadb
force-pushed
the
wip
branch
3 times, most recently
from
2088439
to
b61c0e7
Compare
|
gonna close this i think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.