Support users embedding fql snippets in objects and arrays #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-3501
Problem
Query
instances (i.e. results from thefql
function) cannot be encoded when embedded in objects or arrays.The
QueryValue
type is incorrectly used for types over the wire.Solution
The database now accepts a query interpolation fragments for
array
andobject
, where the existingfql
fragment can now be nested under thearray
andobject
fragments. Add newencodeInterpolation
method to encode with the new fragments.Query
arguments
do not use interpolation, so they still need the@object
tag. Encoding arguments still uses the existingencode
method.Update types to better distinguish between
Query
within objects and arraysQueryValue
should remain a validQueryArgument
to ensure round-trip-abilityQueryValue
from fragmentsQueryValue
type only where we decode values from Fauna.Result
Queries can be encoded in QueryInterpolations.
Queries can be embedded within JS arrays and objects.
Type changes are corrections to the internal implementation. No user-facing changes were made to types.
Out of scope
n/a
Testing
Updated existing tests and added new ones for embedding queries in arrays and objects.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.