[exporter/dynatrace] do not disable when module temporarily disabled (o…

…pen-telemetry#7161)

* fix(dt): do not disable exporter when module temporarily disabled

CHANGELOG.md

@@ -10,6 +10,7 @@
 - `datadogexporter`: Add http.status_code tag to trace stats (#6889)
 - `tanzuobservabilityexporter`: Support delta histograms (#6897)
 - `mysqlreceiver`: Add the receiver to available components (#7078)
+- `dynatraceexporter`: Do not shut down exporter when metrics ingest module is temporarily unavailable (#7161)
 
 ## 🛑 Breaking changes 🛑
 

exporter/dynatraceexporter/metrics_exporter.go

@@ -237,15 +237,18 @@ func (e *exporter) sendBatch(ctx context.Context, lines []string) error {
  return nil
  }
 
- if resp.StatusCode == http.StatusUnauthorized || resp.StatusCode == http.StatusForbidden {
- // Unauthorized and Unauthenticated errors are permanent
+ if resp.StatusCode == http.StatusUnauthorized {
+ // token is missing or wrong format
  e.isDisabled = true
- return consumererror.NewPermanent(fmt.Errorf(resp.Status))
+ return consumererror.NewPermanent(fmt.Errorf("API token missing or invalid"))
+ }
+
+ if resp.StatusCode == http.StatusForbidden {
+ return consumererror.NewPermanent(fmt.Errorf("API token missing the required scope (metrics.ingest)"))
  }
 
  if resp.StatusCode == http.StatusNotFound {
- e.isDisabled = true
- return consumererror.NewPermanent(fmt.Errorf("dynatrace metrics ingest module is disabled"))
+ return consumererror.NewPermanent(fmt.Errorf("metrics ingest v2 module not found - ensure module is enabled and endpoint is correct"))
  }
 
  // No known errors

exporter/dynatraceexporter/metrics_exporter_test.go

@@ -341,8 +341,8 @@ func Test_exporter_send_NotFound(t *testing.T) {
  t.Errorf("Expected error to be permanent %v", err)
  return
  }
- if !e.isDisabled {
- t.Error("Expected exporter to be disabled")
+ if e.isDisabled {
+ t.Error("Expected exporter to not be disabled")
  return
  }
 }