Fix check of runner OS in test Action #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an if statement that checks if the current runner is a Ubuntu machine. Check if "ubuntu" is part of the `matrix.os` instead of comparing if the `matrix.os` matches "ubuntu" completely. This modification is needed after the changes introduced in #499.
santisoler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an if statement that checks if the current runner is a Ubuntu machine. Instead of comparing the
matrix.osvariable, rely on the$RUNNER_OSenv variable provided by Actions. Add echo commands to increase verbosity.Relevant issues/PRs:
Changes motivated by the modifications introduced in #499