Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant urls in pyproject.toml #488

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Remove redundant urls in pyproject.toml #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c876061
Remove redundant urls in pyproject.toml
santisoler Apr 8, 2024
8828caa
Merge branch 'main' into pyproject-urls
santisoler Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,10 @@ dependencies = [
]

[project.urls]
"Homepage" = "https://www.fatiando.org/harmonica"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the link of the documentation

Copy link
Member Author

@santisoler santisoler Apr 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment @VascoSch92. In fatiando/choclo#77 we agreed that it's redundant to have Homepage and Documentation urls pointing to the same website. This is why I'm removing Homepage and leaving Documentation only.

I think it's nice to have Homepage and Documentation in case a project has its docs and website in different urls, like xarray (https://pypi.org/project/xarray). But for Harmonica it might be redundant since its website it's its docs.

Do you agree?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok ;)

Thanks for the clarification

"Documentation" = "https://www.fatiando.org/harmonica"
"Repository" = "https://github.com/fatiando/harmonica.git"
"Changelog" = "https://www.fatiando.org/harmonica/latest/changes.html"
"Bug Tracker" = "https://github.com/fatiando/harmonica/issues"
"Source Code" = "https://github.com/fatiando/harmonica"
"Release Notes" = "https://github.com/fatiando/harmonica/releases"

[project.optional-dependencies]
visualizations = ["pyvista>=0.27", "vtk>=9"]
Expand Down