Add tilt transformation #486
Conversation
* added `tilt` function to `_transformations.py` * added it to the `index.rst` * created an example in `tilt.py` * added it to `__init__.py` * added the class `TestTilt` in `test_transformations.py`; however, the test is failling.
For some reason that I don't know the test of tilt passes when you change the sinal of g_z in `TestTilt:test_against_synthetic` in `test_transformations.py`
There was a problem hiding this comment.
Thanks for this @leomiquelutti! Made a few comments but nothing major. Good work!
Co-authored-by: Leonardo Uieda <[email protected]>
* changed from `tilt` to `tilt_angle` * added Miller and Sing 1994 reference
|
Do you know why the test for macOS for python 3.8 is failing and/or how to solve it, @leouieda? |
|
It was due to a failure when trying to push the coverage report to Codecov. I reran it and now it's passing. Nothing wrong with your code ❤️ |
There was a problem hiding this comment.
Sorry @leomiquelutti for the delay. I went through the PR and left a few comments below. Nothing critical, just some suggestions. Let me know what do you think, and feel free to ask for help, I can apply some changes myself if you are too busy.
I think we can squeeze this PR in the next Harmonica release! 🚀 Thanks a lot for your contribution!
| grid=magnetic_grid, | ||
| projection="X?", | ||
| cmap=True, | ||
| # frame=["a", "+tMagnetic anomaly intensity (TMI)"], |
There was a problem hiding this comment.
Would be nice to add a title here. Otherwise, we should remove this line.
There was a problem hiding this comment.
Hi @santisoler,
I left the frames (titles) with comments because I could not add titles to the images in a way that would look good. Right now I am struggling with the installation of pygmt (again, I always suffer with that under Windows) to try to solve it.
If you would like to address it, I encourage you 😁. Otherwise, I will probably remove them.
| grid=rtp_grid, | ||
| projection="X?", | ||
| cmap=True, | ||
| # frame=["a", "+tTMI reduced to the pole (RTP)"], |
| grid=tilt_grid, | ||
| projection="X?", | ||
| cmap=True, | ||
| # frame=["a", "+tTilt from TMI"], |
| grid=tilt_rtp_grid, | ||
| projection="X?", | ||
| cmap=True, | ||
| # frame=["a", "+tTilt from RTP"], |
Co-authored-by: Santiago Soler <[email protected]>
Co-authored-by: Santiago Soler <[email protected]>
Co-authored-by: Santiago Soler <[email protected]>
Co-authored-by: Santiago Soler <[email protected]>
Co-authored-by: Santiago Soler <[email protected]>
fixed TestTilt::test_against_synthetic
Changes proposed:
tiltfunction to_transformations.pyindex.rsttilt.py__init__.pyTestTiltintest_transformations.pySome points/questions:
TestTilt::test_against_syntheticis failing and I don't know why.tilt.pyrequire a title. I added but had a hard time with pyGMT, so I left them commented..pyfile, comparing the transformations from TMI to the ones from RTP TMI. But that should be done in another PR.transformations.rst?Can you please help me @santisoler.