Print xarray objects in user guide #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print `xarray.DataArray` and `xarray.Dataset` objects in the user guide pages instead of display them and letting Jupyter to render them as HTML objects. This is a patch to output cells not rendering properly on Sphinx dark mode.
|
This is a known issue in xarray: pydata/xarray#8097 (comment) I think we could just wait for a fix on their part. What do you think? |
|
It's fine for me, @leouieda. I think we can go back to this PR before making the next Harmonica release and see if the problem was solved upstream. Otherwise we can apply this quick fix, release, and revert it in a future, when the displays look nice on dark theme. Does it make sense? |
|
I'm closing this PR for now, but I'm not deleting the branch in case we need to get these changes back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print
xarray.DataArrayandxarray.Datasetobjects in the user guide pages instead of display them and letting Jupyter to render them as HTML objects. This is a patch to output cells not rendering properly on Sphinx dark mode.Relevant issues/PRs:
This intends to patch the xarray issue mentioned in #472