Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depth_type from EquivalentSources #468

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Mar 5, 2024

Remove the depth_type argument from the EquivalentSources constructor. By default the point sources will be defined using a relative depth strategy. Removed the deprecated relative_depth argument from the constructor. Update the tests for the class and its methods.

Todo:

  • remove depth_type from gradient boosted equivalent sources and update their tests
  • remove depth_type from the docs (if any)
  • check if we need to update the spherical equivalent sources as well

Relevant issues/PRs:

Fixes #423

santisoler and others added 5 commits March 5, 2024 09:57
Remove the depth_type argument from the EquivalentSources constructor.
By default the point sources will be defined using a relative depth
strategy. Removed the deprecated relative_depth argument from the
constructor. Update the tests for the class and its methods.
@santisoler santisoler marked this pull request as ready for review March 19, 2024 18:31
@santisoler santisoler added this to the v0.7.0 milestone Mar 25, 2024
@santisoler
Copy link
Member Author

Co-authored by @indiauppal as well during a Fatiando Meeting in which we all worked together on this code.

@santisoler santisoler merged commit 07d3cf9 into fatiando:main Apr 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the depth_type argument from equivalent sources
3 participants