Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pylint to 2.2.2 and fix numpy-related lint #45

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Conversation

leouieda
Copy link
Member

Pylint has started complaining about numpy imports. Disable these checks
and add numpy to their whitelist. Pin the pylint version so that this
type of errors doesn't creep up on new PRs and we upgrade pylint only
when we want to.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Pylint has started complaining about numpy imports. Disable these checks
and add numpy to their whitelist. Pin the pylint version so that this
type of errors doesn't creep up on new PRs and we upgrade pylint only
when we want to.
@leouieda leouieda merged commit 775df19 into master Feb 21, 2019
@leouieda leouieda deleted the pylint-errors branch February 21, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant