Use a text field for license in pyproject.toml #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the "file" field type, PyPI putting the entire contents of the file into the license field and mislabeling it as MIT. Replace it with just the string for the license name and not the contents of the file/
|
See https://test.pypi.org/project/harmonica/ for the incorrect output. |
|
Nice catch @leouieda! |
|
Ah no wait, there is also the classifier causing problems. |
|
Can't fix it now, gotta run |
|
Alright, done! Ready for a review. I made a few tweaks as well to put fields closer to other relevant fields. |
santisoler
reviewed
Nov 20, 2023
| keywords = ["geoscience", "geophysics"] | ||
| classifiers = [ | ||
| "Programming Language :: Python :: 3", | ||
| "License :: OSI Approved :: MIT License", | ||
| "License :: OSI Approved :: BSD License", |
|
I'm merging this. Thanks @leouieda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "file" field type, PyPI putting the entire contents of the file into the license field and mislabeling it as MIT. Replace it with just the string for the license name and not the contents of the file.