Use only strings in xarray.Dataset metadata #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
harmonica.load_icgem_gdf
function populated theDataset.attrs
with metadata derived from the file header. Two of these fields
(
attributes
andattributes_units
) were lists. This was fine whileusing xarray with netcdf4 but it does not work if trying to use scipy to
save/load the
Dataset
. And since xarray 0.11 stopped installingnetcdf4 automatically, we can't load our sample gravity and topography
data without adding netcdf4 as a dependency.
Instead of doing that,
load_icgem_gdf
now converts the metadata tostrings. New copies of the two sample grids have been generated using
scipy (netcdf3).
cc @santis19
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.