Refactor tesseroids and enable parallelization #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the glq_degrees, stack_size and max_discretizations arguments and set them as global variables. These parameters are not usually changed by users, it's better to hide them and declutter the `tesseroid_gravity` function.
The distance-size ratii are now passed through the global variable DISTANCE_SIZE_RATII. Removed test function for invalid `distance_size_ratii` argument.
Split the original tesseroid_gravity function into a new private one so the code gets simplified. Unsilence pylint warning for too-many-locals on tesseroid_gravity. Set consistent naming of `radial_adaptive_discretization` argument among functions.
santisoler
force-pushed
the
refactor-tesseroids
branch
from
1349199
to
e79f272
Compare
Enable parallelization through Numba prange on the computation points loop. Both the stack and the small_tesseroids arrays are allocated inside the same loop to avoid multiple threads to override the same memory. Add a new parallel argument to tesseroid_gravity and a new dispatcher function that returns either the parallel or serial jitted function.
santisoler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some pieces of the tesseroids implementation. Lower the number of
arguments of
tesseroid_gravityby removing some parameters and used them asglobal variables:
GLQ_DEGREES,STACK_SIZE,MAX_DISCRETIZATIONS,DISTANCE_SIZE_RATII. These parameters are not intended to be changed by theuser on most use cases. Enable parallelization of the forward model through
Numba
parallel. Allow to disable it through a newparallelargument, setTrueby default. The outer loop that iterates over computation points is theone being parallelized. A new
stackandsmall_tesseroidsarrays areallocated for each outer loop iteration. Improve some old-dated docstrings.
Refactor tests using
pytestparametrizations.