Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Sphinx #224

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Unpin Sphinx #224

merged 2 commits into from
Apr 13, 2021

Conversation

santisoler
Copy link
Member

Unpin sphinx from environment.yml and requirements-dev.txt.
Solve the toctree issue where the p tags were not getting a caption
class.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

Unpin `sphinx` from `environment.yml` and `requirements-dev.txt`.
Solve the toctree issue where the p tags were not getting a `caption`
class.
@santisoler santisoler changed the title Unpin Sphinx from dependencies Unpin Sphinx Apr 13, 2021
@santisoler santisoler merged commit bafc8c3 into master Apr 13, 2021
@santisoler santisoler deleted the unpin-sphinx branch April 13, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant