Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ellipsoid code in favour of Boule #137

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Remove the ellipsoid code in favour of Boule #137

merged 1 commit into from
Jan 14, 2020

Conversation

leouieda
Copy link
Member

The ellipsoid code, together with the coordinate conversions and normal
gravity have been moved to Boule. Remove the associated code from
Harmonica and use Boule in the tests and examples that require it.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

The ellipsoid code, together with the coordinate conversions and normal
gravity have been moved to Boule. Remove the associated code from
Harmonica and use Boule in the tests and examples that require it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants