Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Rio magnetic data #132

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Remove the Rio magnetic data #132

merged 2 commits into from
Dec 9, 2019

Conversation

leouieda
Copy link
Member

Now that we have the Great Britain magnetic survey (which has a proper
open license) we don't need the Rio one (which is ambiguous). Remove the
dataset and loading function. Replace its use in the gallery with the
Britain data.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Now that we have the Great Britain magnetic survey (which has a proper
open license) we don't need the Rio one (which is ambiguous). Remove the
dataset and loading function. Replace its use in the gallery with the
Britain data.
Copy link
Member

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me @leouieda! 🥇

@leouieda leouieda merged commit f2878be into master Dec 9, 2019
@leouieda leouieda deleted the remove-rio branch December 9, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants