Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pooch.Decompress to load sample grids #118

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Conversation

leouieda
Copy link
Member

@leouieda leouieda commented Nov 1, 2019

The new pooch processor class removes the need for our custom
function that loads the xz compressed sample grids of global gravity,
geoid, and topography.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

The new pooch processor class removes the need for our custom
function that loads the xz compressed sample grids of global gravity,
geoid, and topography.
Copy link
Member

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@leouieda leouieda merged commit 18f74bd into master Nov 2, 2019
@leouieda leouieda deleted the use-pooch-decompress branch November 2, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants