Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for invalid density array #104

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

santisoler
Copy link
Member

Add size of density array and number of tesseroids on the error message
when they mismatch in order to make clearer what's failing.

The improvement of such error messages was triggered after #98.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Add size of density array and number of tesseroids on the error message
when they mismatch in order to make clearer what's failing.
@leouieda
Copy link
Member

Nice 🍻 Thanks, Santi

@leouieda leouieda merged commit 191f32c into master Sep 24, 2019
@leouieda leouieda deleted the density_error_msg branch September 24, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants