Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal gravity calculation #7

Closed
leouieda opened this issue Oct 18, 2018 · 0 comments · Fixed by #14
Closed

Normal gravity calculation #7

leouieda opened this issue Oct 18, 2018 · 0 comments · Fixed by #14
Assignees
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)
Milestone

Comments

@leouieda
Copy link
Member

Description of the desired feature

The normal gravity calculation should be done using the Li and Goetze (2001) formula that allows computation at any height. It would use the current ellipsoid (harmonica.get_ellipsoid) to do the calculations. This is what the function signature should look like:

def normal_gravity(latitude, height):
    ...
    return result

Latitude and heights can be any array like object so it's best to do the calculations with numpy functions instead of math.

It might be a bit tricky to test. One way is to compare the computed values at the equator and pole with the ones provided by the ReferenceEllipsoid (which are tested against Hofmann-Wellenhof & Moritz, 2006). That should probably be enough.

@leouieda leouieda added enhancement Idea or request for a new feature help wanted good first issue Good for newcomers (doesn’t require deep knowledge of the project) labels Oct 18, 2018
@leouieda leouieda added this to the v0.1.0 milestone Oct 18, 2018
@santisoler santisoler self-assigned this Oct 29, 2018
leouieda pushed a commit that referenced this issue Nov 6, 2018
Added normal_gravity function to compute the normal gravity at any latitude and height.
Uses the current default ellipsoid from get_ellipsoid.
Added verde as a dependency.

Fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants